refactor(lib): mirror the PR #210 review changes onto main - #19
Merged
Conversation
…lper
Two naming points from review:
- `explainDataError` claimed more than it does, so it is now
`explainCodecError` (and `TDataErrorExplanation` follows it to
`TCodecErrorExplanation`).
- `flattenErrorMessage` is not codec-specific at all — it moves to
`src/utils/errorHandling.ts` next to `getErrorMessage` and
`toNormalizedError`, with its unit tests alongside it in
`tests/unit/utils/errorHandling.test.ts`.
No behaviour change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0162gtw32ckX3EFQFPqs74dN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream review on d70-t/gridlook#210 asked for two naming changes:
explainDataError->explainCodecError(andTDataErrorExplanation->TCodecErrorExplanation)flattenErrorMessagemoved out ofsrc/lib/data/codecErrors.tsintosrc/utils/errorHandling.ts, with its unit tests alongside it intests/unit/utils/errorHandling.test.tsThose are already pushed to
fix/codec-error-messages.CLAUDE.mdrequirescodecErrors.tsand its test to stay byte-identical between that branch andmain, so this cherry-picks the same commit here.No behaviour change. Typecheck,
lint-ciand the full suite (216 tests) pass.